[FLINK-32893][Connectors/Kafka] Allow the clientid to be fully configurable #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening this pull request! Please check out our contributing guidelines. (https://flink.apache.org/contributing/how-to-contribute.html) |
|
@bdbene Can you please rebase your PR? |
|
Done :) |
|
@bdbene Please rebase instead of merging, since we can't merge in merge commits |
bdbene
force-pushed
the
FLINK-32893-fully-configurable-cliendid
branch
from
ba3b9e6
to
ed3d92f
Compare
|
Oops, fixed that |
jychen7
reviewed
Aug 5, 2024
| @@ -36,6 +36,14 @@ public class KafkaSourceOptions { | |||
| .noDefaultValue() | |||
| .withDescription("The prefix to use for the Kafka consumers."); | |||
|
|
|||
| public static final ConfigOption<String> COMPLETE_CLIENT_ID = | |||
| ConfigOptions.key("client.id.complete") | |||
There was a problem hiding this comment.
Suggested change
| ConfigOptions.key("client.id.complete") | |
| ConfigOptions.key("client.id") |
shall we just use the same config as kafka clients?
I agree this would NOT be backwards compatible in Flink source, but more align with Kafka clients
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
FLINK-32893
There's some use cases to use the same clientID across all of the low level Kafka consumers to
Brief Change Log
Support an optional configuration for the exact clientID to run Kafka consumers with
Verifying this change
It's difficult to write unit tests for this which is probably why there's no existing unit tests for the client ID. However I was able to run this locally and could see the client ID was logged exactly as I specified it (no prefix or suffix).