[FLINK-33207] Return empty split when the hbase table is empty #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tan-JiaLiang
force-pushed
the
FLINK-33207
branch
from
7f4370a
to
ca655c9
Compare
|
@ferenc-csaky can you also help with this one? |
Tan-JiaLiang
force-pushed
the
FLINK-33207
branch
from
ca655c9
to
445e606
Compare
Tan-JiaLiang
force-pushed
the
FLINK-33207
branch
from
445e606
to
bbba20d
Compare
ferenc-csaky
approved these changes
Nov 10, 2023
There was a problem hiding this comment.
Now that a check was implemented to deliberately verify if a table exists in #22 this makes sense, throwing that previous error at that point is now wrong and misleading.
LGTM! If tests pass -> 🚢
MartijnVisser
approved these changes
Nov 10, 2023
MartijnVisser
pushed a commit
that referenced
this pull request
Nov 10, 2023
…loses #23 Co-authored-by: tanjialiang <[email protected]> (cherry picked from commit 4b33c32)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
If the hbase table is empty, it will throw an error when
createInputSplits, we should return empty split instead.Brief change log
Verifying this change
This change is already covered by existing tests, such as