-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FLINK-28013] Shade all netty dependencies in sql jar #17
Conversation
Thanks for opening this pull request! Please check out our contributing guidelines. (https://flink.apache.org/contributing/how-to-contribute.html) |
@MartijnVisser PTAL |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@whhe The connector actually shouldn't rely on flink-shaded
at all.
It will not depend on 'flink-shaded', this modification is to add netty packages other than 'netty-all', such as 'netty-transport' here, to the sql jar. |
Ah sorry, I misread. I'll try to have a look later today |
Any progress? @MartijnVisser |
I tested this patch locally which resolves this NoClassDefFoundError exception; |
Hello again @MartijnVisser, please take a look on this pr if you are available. It wouldn't take a long time. |
Awesome work, congrats on your first merged pull request! |
Shade all netty dependencies to resolve
java.lang.NoClassDefFoundError: org/apache/flink/hbase/shaded/io/netty/channel/EventLoopGroup
.