[hotfix] Fix SUBSTR built-in function testcases #3696
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: yuxiqian <[email protected]>
yuxiqian
changed the title
leonardBang
approved these changes
Nov 8, 2024
There was a problem hiding this comment.
Thanks @yuxiqian for the quick fix, will merge once CI pass
|
Done, all passing. |
|
CI passed ,merging... |
yuxiqian
added a commit
to yuxiqian/flink-cdc
that referenced
this pull request
Nov 8, 2024
…ilt-in function is 1-based index now This closes apache#3696 (cherry picked from commit 5184c01)
Gianzie
pushed a commit
to Gianzie/flink-cdc
that referenced
this pull request
Nov 12, 2024
…ilt-in function is 1-based index now This closes apache#3696
yuxiqian
added a commit
to yuxiqian/flink-cdc
that referenced
this pull request
Nov 13, 2024
…ilt-in function is 1-based index now This closes apache#3696 (cherry picked from commit 5184c01)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #3537 and #3592 has some implicit conflicts that will cause CI failure.
#3537 changes
SUBSTRfunction to 1-based index and corresponding test cases in #3592 didn't get updated yet.