-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[tests][ci] Refactor ci #3626
[tests][ci] Refactor ci #3626
Conversation
Thanks for @GOODBOY008's great work! A little suggestion: is it possible to split jobs into sub-workflow files to organize them by categories? Current there are a little too much jobs, and most of them has only one sub-task |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
c3ae751
to
1d0e0b8
Compare
@yuxiqian The pr just for test ci, I will add my commit to your pr.We usually check the failed CI jobs in the CI job view on the PR page, so I don't think it's necessary. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
Categorized folders aren't that important. Could be done later if it takes too much efforts to do now.
661e149
to
e74bc38
Compare
.github/workflows/flink_cdc_base.yml
Outdated
flink-cdc-connect/flink-cdc-pipeline-connectors/flink-cdc-pipeline-connector-doris,\ | ||
flink-cdc-connect/flink-cdc-pipeline-connectors/flink-cdc-pipeline-connector-starrocks,\ | ||
flink-cdc-connect/flink-cdc-pipeline-connectors/flink-cdc-pipeline-connector-kafka,\ | ||
flink-cdc-connect/flink-cdc-pipeline-connectors/flink-cdc-pipeline-connector-paimon" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Somehow Elasticsearch connector tests have never been added into CI...
e74bc38
to
2fd1bea
Compare
2fd1bea
to
700eced
Compare
Thanks @GOODBOY008 for this great work. |
@Jiabao-Sun I think we can discuss later. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Jiabao-Sun Do you mean specifying the Flink version and passing it to run tests using a custom Maven parameter, while the default Flink version corresponds to the project’s dependency version?
I think we can discuss later.
Yes, but we can do it later.
cc @leonardBang
No description provided.