Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ISSUE #4866] Add unified deps version identifier & Upgrade Gradle from 8.2.1 to 8.7 #4867

Merged
merged 9 commits into from
May 24, 2024
Merged

[ISSUE #4866] Add unified deps version identifier & Upgrade Gradle from 8.2.1 to 8.7 #4867

merged 9 commits into from
May 24, 2024

Conversation

Pil0tXia
Copy link
Member

@Pil0tXia Pil0tXia commented Apr 25, 2024 •
edited
Loading

Fixes #4866

Motivation

It's a routine upgrade.

Benchmark

Gradle 8.2.1

Local machine, with build cache:

image

Gradle 8.7

Local machine, with build cache:

image

Deprecation

https://docs.gradle.org/8.7/userguide/upgrading_version_8.html#project_builddir

Modifications

Documentation

  • Does this pull request introduce a new feature? (no)

@Pil0tXia
Copy link
Member Author

Pil0tXia commented Apr 25, 2024 •
edited
Loading

Well, known dependency check failed. Please merge #4827 first and no more known-dependencies~

@Pil0tXia
Copy link
Member Author

Pil0tXia commented May 18, 2024 •
edited
Loading

I will resolve conflicts later.

@Pil0tXia Pil0tXia mentioned this pull request May 18, 2024
Closed
@Pil0tXia Pil0tXia changed the title [ISSUE #4866] Upgrade Gradle from 8.2.1 to 8.7 [ISSUE #4866] Add unified version identifier & Upgrade Gradle from 8.2.1 to 8.7 May 18, 2024
This was referenced May 18, 2024
Closed
Closed
@Pil0tXia Pil0tXia added the ready for review PR is waiting for reviewer's approval or opinion (used as a strong reminder) label May 18, 2024
This was referenced May 18, 2024
Closed
Closed
@Pil0tXia Pil0tXia changed the title [ISSUE #4866] Add unified version identifier & Upgrade Gradle from 8.2.1 to 8.7 [ISSUE #4866] Add unified deps version identifier & Upgrade Gradle from 8.2.1 to 8.7 May 18, 2024
This was referenced May 20, 2024
Closed
Merged
pchengma
pchengma approved these changes May 22, 2024
View reviewed changes
Copy link
Member

@pchengma pchengma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@mxsm mxsm merged commit 152e48f into apache:master May 24, 2024
10 checks passed
@Pil0tXia Pil0tXia deleted the pil0txia/gradle_4866 branch May 24, 2024 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pchengma pchengma pchengma approved these changes

@mxsm mxsm mxsm approved these changes

Assignees
No one assigned
Labels
ready for review PR is waiting for reviewer's approval or opinion (used as a strong reminder)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Enhancement] Upgrade Gradle from 8.2.1 to 8.7
3 participants
@Pil0tXia @mxsm @pchengma