Skip to content
This repository has been archived by the owner on May 12, 2021. It is now read-only.

[EAGLE-906] org.apache.storm 1.x with API changes #812

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

jhsenjaliya
Copy link
Contributor

tested on MR Running and MR history app.

@jhsenjaliya jhsenjaliya changed the title [EAGLE-906] updating to use org.apache.storm==1.0.3 with compatibilit… [EAGLE-906] org.apache.storm 1.x with API changes Feb 16, 2017
@jhsenjaliya jhsenjaliya changed the base branch from master to branch-0.5-storm_1.x February 17, 2017 11:01
@haoch
Copy link
Member

haoch commented Feb 18, 2017

@jhsenjaliya building failed, could you please check again?

@jhsenjaliya jhsenjaliya force-pushed the EAGLE-906 branch 3 times, most recently from ea74430 to 51ed88c Compare February 18, 2017 09:11
@haoch
Copy link
Member

haoch commented Feb 21, 2017

Have you tested about consuming kafka:0.8.1 with storm-kafka:1.0.2 ?

@jhsenjaliya
Copy link
Contributor Author

jhsenjaliya commented Feb 22, 2017

i havent explicitly tested it, but from storm-kafka:1.0.2 docs, it looks compatible with kafka 0.8.1.1 which is used in the example given on that page.
Also eagle repo includes kafka 0.8.2.2, wouldnt it test the compatibility?
is there any other way we can test this?

@haoch
Copy link
Member

haoch commented Feb 22, 2017

Just worry about possible compatibility issue as kafka which was refactored a lot recently and here are some tricky dependencies behavior in storm-kafka

@jhsenjaliya
Copy link
Contributor Author

ok, I m digging further into this, I will try running some apps. pls let me know if you have any other suggestions.

@jhsenjaliya
Copy link
Contributor Author

@haoch, I tested all of these change with kafka_2.11-0.8.2.2 and it works fine.
I ran hdfs audit log and alert application to test.

@jhsenjaliya jhsenjaliya changed the base branch from branch-0.5-storm_1.x to master March 18, 2017 09:07
@jhsenjaliya
Copy link
Contributor Author

need to rebase branch-0.5-storm_1.x with master. changing the base to master for time being.

@jhsenjaliya
Copy link
Contributor Author

i will update this PR with storm 1.1.0 and rebase it after 0.5 release.

@r7raul1984
Copy link

@jhsenjaliya In my opition , I don't think it is good time to upgrade storm to 1.1.0. In my experience ,many companies do not use the latest version .If you insist to upgrade storm, I recommend we should support multi storm version (like hive shims moudle) and do more integration test instead of unit test by mock.

@jhsenjaliya
Copy link
Contributor Author

@r7raul1984 , that is a good point, but this is intended for 0.6 release which will have enough time to take a minor versions with bug fixes if any ( or we can also simply stick to 1.0.x but I would like to compare both 1.0.x and 1.1.x in terms of improvements before change) .

I also agree on exploring a way to support multi version shims way.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants