This repository has been archived by the owner on May 12, 2021. It is now read-only.
[EAGLE-1096] getJSONArray may cause exception, optJSONArray can be used #1001
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhsenjaliya
reviewed
Apr 14, 2019
| @@ -56,7 +56,7 @@ | |||
| final Map<String, JMXBean> resultMap = new HashMap<String, JMXBean>(); | |||
| final JSONTokener tokener = new JSONTokener(is); | |||
| final JSONObject jsonBeansObject = new JSONObject(tokener); | |||
| final JSONArray jsonArray = jsonBeansObject.getJSONArray("beans"); | |||
| final JSONArray jsonArray = jsonBeansObject.optJSONArray("beans"); | |||
| int size = jsonArray.length(); | |||
There was a problem hiding this comment.
if jsonArray is going to be null, can u add that handling as well ? Thanks
There was a problem hiding this comment.
Agree with @jhsenjaliya, this change will incur the NPE issue.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Be sure to do all of the following to help us incorporate your contribution
quickly and easily:
[EAGLE-<Jira issue #>] Description of pull requestmvn clean verify. (Even better, enableTravis-CI on your fork and ensure the whole test matrix passes).
<Jira issue #>in the title with the actual Jira issuenumber, if there is one.
Individual Contributor License Agreement.