Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[optimize] Replace dubbo-demo-native #14877

Closed
wants to merge 7 commits into from
Closed

Conversation

heliang666s
Copy link
Contributor

@heliang666s heliang666s commented Nov 8, 2024

What is the purpose of the change?

#14878

  1. Remove dubbo-demo-native
  2. Modify dubbo-demo-springboot to support native functionality
  3. Modify related github-action files

Checklist

  • Make sure there is a GitHub_issue field for the change.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Make sure gitHub actions can pass. Why the workflow is failing and how to fix it?

@codecov-commenter
Copy link

codecov-commenter commented Nov 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 2.19%. Comparing base (ef6e8bd) to head (1f45da0).
Report is 55 commits behind head on 3.3.

Additional details and impacted files
@@              Coverage Diff              @@
##              3.3    #14877        +/-   ##
=============================================
- Coverage   37.53%     2.19%    -35.34%     
=============================================
  Files        1813     26083     +24270     
  Lines       80737   1389674   +1308937     
  Branches    12005    220210    +208205     
=============================================
+ Hits        30304     30560       +256     
- Misses      46042   1354672   +1308630     
- Partials     4391      4442        +51     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AlbumenJ
Copy link
Member

@CrazyHZM PTAL

Copy link
Contributor

@FoghostCn FoghostCn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

native demo run failed, pls fix CI

Copy link
Contributor

@wcy666103 wcy666103 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why remove this?

registry:
id: zk-registry
address: zookeeper://127.0.0.1:2181
config-center:
address: zookeeper://127.0.0.1:2181
metadata-report:
address: zookeeper://127.0.0.1:2181
metrics:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why remove this?

@heliang666s heliang666s deleted the native branch November 20, 2024 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants