-
Notifications
You must be signed in to change notification settings - Fork 26.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[optimize] Replace dubbo-demo-native #14877
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 3.3 #14877 +/- ##
=============================================
- Coverage 37.53% 2.19% -35.34%
=============================================
Files 1813 26083 +24270
Lines 80737 1389674 +1308937
Branches 12005 220210 +208205
=============================================
+ Hits 30304 30560 +256
- Misses 46042 1354672 +1308630
- Partials 4391 4442 +51 ☔ View full report in Codecov by Sentry. |
@CrazyHZM PTAL |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
native demo run failed, pls fix CI
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why remove this?
registry: | ||
id: zk-registry | ||
address: zookeeper://127.0.0.1:2181 | ||
config-center: | ||
address: zookeeper://127.0.0.1:2181 | ||
metadata-report: | ||
address: zookeeper://127.0.0.1:2181 | ||
metrics: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why remove this?
What is the purpose of the change?
#14878
Checklist