Add per-event JVM GC duration tracking #17472
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Comment on lines
+73
to
+74
| @SuppressWarnings("unused") | ||
| byte[] b = new byte[1024 * 1024 * 50]; |
Check notice
Code scanning / CodeQL
Unread local variable Note test
jtuglu-netflix
force-pushed
the
add-per-event-gc-duration-tracking
branch
from
f4db019
to
a3b7593
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR provides enhances JVM GC metrics to the
JvmMonitormonitor. Namely:jvm/gc/pause: Stop-the-world garbage collection JVM-reported pause time (ms)jvm/gc/concurrentTime: JVM-reported time spent in concurrent phases of CMS pauses (ms)Description
Pulls GC event subscription logic from https://github.com/Netflix/spectator. I'm wondering whether more metrics from this list: https://netflix.github.io/atlas-docs/spectator/lang/java/ext/jvm-gc/#jvmgcpause – we currently take aggregate statistics from getMemoryPoolMXBeans() on total mem usage, etc. via
GcSpaceCollector.Release note
Adds
jvm/gc/pauseandjvm/gc/concurrentTimemetrics to JvmMonitor.Key changed/added classes in this PR
docs/operations/metrics.mdprocessing/src/main/java/org/apache/druid/java/util/metrics/EventBuffer.javaprocessing/src/main/java/org/apache/druid/java/util/metrics/JvmMonitor.javaprocessing/src/main/java/org/apache/druid/java/util/metrics/JvmMonitorConfig.javaprocessing/src/main/java/org/apache/druid/java/util/metrics/Monitors.javaprocessing/src/main/java/org/apache/druid/java/util/metrics/jvm/gc/GcEvent.javaprocessing/src/test/java/org/apache/druid/java/util/metrics/EventBufferTest.javaprocessing/src/test/java/org/apache/druid/java/util/metrics/JvmMonitorTest.javaprocessing/src/test/java/org/apache/druid/java/util/metrics/MonitorsTest.javaserver/src/main/java/org/apache/druid/server/metrics/MetricsModule.javaThis PR has: