supervisor: make rejection periods work with stopTasksCount

[adithyachakilam]

Description

In cases where stopTasksCount is configured which makes streaming tasks run much longer (in some cases) than the configured task duration, early/late rejection periods are not correctly implemented since they are configured during the task startup time in IOConfig. Instead, this PR propagates updates the min/max times once every task duration.

---

Key changed/added classes in this PR

• SeekableStreamIndexTaskRunner
• SeekableStreamIndexTaskIOConfig

---

This PR has:

• been self-reviewed.
  • using the concurrency checklist (Remove this item if the PR doesn't have any relation to concurrency.)
• added documentation for new or modified features or behaviors.
• a release note entry in the PR description.
• added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links.
• added or updated version, license, or notice information in licenses.yaml
• added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
• added unit tests or modified existing tests to cover new code paths, ensuring the threshold for code coverage is met.
• added integration tests.
• been tested in a test Druid cluster.

[suneet-s]

This implementation of refreshing the min / max times every 10 min is a change in behavior, so I think the person submitting the supervisor spec needs to opt in to this new behavior which doesn't appear possible in the current approach.

An alternative approach to consider is to update the IOConfig to include a "refresh interval" field that defaults to infinity that would refresh the min / max times in the IOConfig.

The tasks could then update their min / max times every duration just by adding the refresh interval so we don't need to worry about clock skew across the peons.

Since this patch is meant to just deal with stopTaskCount - have you considered refreshing the min / max times every task duration to mimic the existing behavior if stopTaskCount was not set (aka every task duration the min/max times across all peons are updated)

[suneet-s]

These new fields need to be in addition to the old fields to ensure a newer version of the overlord works with older versions of the indexing tasks. But more importantly, in the case of a rollback - an older overlord needs to work with a newer version of indexing services

[adithyachakilam]

@suneet-s Thanks for the review, I've changed the patch to just update the min/max times once every task duration. So this also avoids all those version problems.

[suneet-s]

I have not reviewed the tests yet.

For this change, we should also include docs for what this new parameter is in the IOConfig

[suneet-s]

Is there an advantage to using Duration? Would it be simpler to pass this in as a long of minutes

Suggested change

	@Nullable final Duration taskDuration // can be null for backward compabitility
	@Nullable final Long refreshRejectionPeriodsInMinutes // can be null for backward compabitility

[adithyachakilam]

I think its good to have Duration and no need to convert back and forth and also confusion of adding mins to the variable. You think there are any issues with the schema deserializing ? (I see at least Period used, maybe we can switch to it if so )

Also, regarding variable name change, Do you think there would be a usecase of user editing it to a different value ? I would prefer to use taskDuration so that no one touches and would also avoid the need for docs (Also, I dont find this documented anywhere, can you point me to the file ?)

[suneet-s]

Is it ok that intelliJ is warning that this is an unsafe update of a volatile variable?

[adithyachakilam]

Yeah its ok.

Its complaining because we are using the same variable to update the value but we only do it once every taskDuration. If it was done more frequently we should have used atomic references.