-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Improvement-16507][Remove spring-boot-starter-cache dependency] Improve the performance of spring-boot-starter-cache #16593
base: dev
Are you sure you want to change the base?
Conversation
Thanks for opening this pull request! Please check out our contributing guidelines. (https://github.com/apache/dolphinscheduler/blob/dev/docs/docs/en/contribute/join/pull-request.md) |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should remove the code and dependency of spring-boot-starter-cache.
Hi ruanwenjun, |
@caishunfeng Can you please guide me to fix 5 failing issues? |
You should check these two dependency. @binitshrest
|
Thank you SbloodyS. I found them. There are so many of these dependencies. Should i remove them too. |
|
@@ -117,7 +117,7 @@ public void setHostAndPortByAddress(String address) { | |||
} | |||
|
|||
this.host = String.join(Constants.COMMA, hosts); | |||
this.port = Integer.parseInt(portString); | |||
this.port = (Integer) Integer.parseInt(portString); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change is not needed
@@ -1,4 +1,4 @@ | |||
# | |||
# |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change is not changed.
<exclusion> | ||
<groupId>org.apache.logging.log4j</groupId> | ||
<artifactId>log4j-to-slf4j</artifactId> | ||
</exclusion> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why remove this?
dolphinscheduler-bom/pom.xml
Outdated
<exclusion> | ||
<groupId>org.apache.logging.log4j</groupId> | ||
<artifactId>log4j-api</artifactId> | ||
</exclusion> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why remove this?
Hi @ruanwenjun, |
This reverts commit cc81bbb.
|
Quality Gate failedFailed conditions See analysis details on SonarCloud Catch issues before they fail your Quality Gate with our IDE extension SonarLint |
This reverts commit cc81bbb.
@SbloodyS Because of so many vulnerabilities found in this project i.e due to old dependencies of mavens. The codebase is failing to build. please allow me to change all the dependencies or any suggestion will appreciated. |
I changed and removed the some extra dependencies that should be removed after removing spring-boot-starter-cache from pom.xml and application.properties file. That has caused the issues. After removing extra dependencies and the server runs smoothly with out any bugs
close #16507