Minor: Clarify use of infallable APIs #13217
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
findepi
reviewed
Nov 1, 2024
| @@ -1554,13 +1554,13 @@ impl Expr { | |||
| /// Returns true if there are any column references in this Expr | |||
| pub fn any_column_refs(&self) -> bool { | |||
| self.exists(|expr| Ok(matches!(expr, Expr::Column(_)))) | |||
| .unwrap() | |||
| .expect("exists closure is infallible") | |||
There was a problem hiding this comment.
It's fine, but would it be possible to make .exists not return Result at all when closure doesn't return it?
would doing Try same way as iter.try_fold does work here too?
There was a problem hiding this comment.
I suppose we could rename exists to try_exists and then switch exists to not be fallable 🤔
There was a problem hiding this comment.
i tried to model this in a generic way with something like
F: Fn -> R
R: MaybeFallible<bool>
```
```
trait MaybeFallible<T> {
fn is_falure(&self) -> bool;
fn as_value(&self) -> Option<&T>;
```
It's sufficient to model the `exists` function signature generically, but i couldn't get exist and apply both working (perhaps didn't try long enough)
findepi
approved these changes
Nov 1, 2024
github-actions
bot
removed
the
documentation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Follow on ot
Expr::volatileinfallible #13206Rationale for this change
Implement @findepi 's suggestion in #13206 (comment)
What changes are included in this PR?
Make the uses of
existswith an infallable closure (aka never returns Err) clearAre these changes tested?
By CI
Are there any user-facing changes?
No