Fix check_not_null_constraints null detection #13033
Merged
+144
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
findepi
commented
Oct 21, 2024
Comment on lines
+889
to
+894
| if batch | ||
| .column(index) | ||
| .logical_nulls() | ||
| .map(|nulls| nulls.null_count()) | ||
| .unwrap_or_default() | ||
| > 0 |
There was a problem hiding this comment.
This could be simplified back if we had something like apache/arrow-rs#6608
findepi
force-pushed
the
findepi/check-constraint
branch
from
1d34535
to
e0440a2
Compare
findepi
commented
Oct 21, 2024
`check_not_null_constraints` (aka `check_not_null_contraits`) checked for null using `Array::null_count` which does not return real null count.
findepi
force-pushed
the
findepi/check-constraint
branch
from
e0440a2
to
726c295
Compare
alamb
approved these changes
Oct 22, 2024
|
Thanks again @findepi |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
check_not_null_constraints(akacheck_not_null_contraits) checkedfor null using
Array::null_countwhich does not return real nullcount.