Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename TokenWithLocation to TokenWithSpan, in backwards compatible way #1562

Merged
merged 1 commit into from
Nov 30, 2024
Merged

Rename TokenWithLocation to TokenWithSpan, in backwards compatible way #1562

merged 1 commit into from
Nov 30, 2024

Conversation

alamb
Copy link
Contributor

@alamb alamb commented Nov 26, 2024

Rationale

While working on

I noticed that TokenWithLocation was confusingly named as after #1435 it contains a Span rather than a Location

Changes

  1. Rename TokenWithLocation to TokenWithSpan
  2. Leave a (deprecated) typedef pointing at TokenWithLocation to help migration

@alamb alamb mentioned this pull request Nov 26, 2024
Merged
2 tasks
@alamb alamb marked this pull request as ready for review November 26, 2024 18:59
iffyio
iffyio approved these changes Nov 28, 2024
View reviewed changes
Copy link
Contributor

@iffyio iffyio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@alamb alamb merged commit a134910 into apache:main Nov 30, 2024
8 checks passed
@alamb
Copy link
Contributor Author

alamb commented Nov 30, 2024

Thanks @iffyio

@alamb alamb deleted the alamb/deprecate_token_with_location branch November 30, 2024 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iffyio iffyio iffyio approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alamb @iffyio