Add support for data type specific methods #1535
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iffyio
reviewed
Nov 23, 2024
Comment on lines
+1228
to
+1236
| let namespace = w.value; | ||
| self.expect_token(&Token::DoubleColon)?; | ||
| let name_with_namespace = match self.next_token().token { | ||
| Token::Word(func_name) => { | ||
| ObjectName(vec![Ident::new(format!("{}::{}", namespace, func_name.value))]) | ||
| }, | ||
| _ => return self.expected("identifier", self.peek_token()) | ||
| }; | ||
| Ok(self.parse_function(name_with_namespace)?) |
There was a problem hiding this comment.
Can we move the body to a self.parse_namespaced_method(w)? or similar function? Also if we can add an example syntax to the function doc with the link to clarify the syntax
| @@ -11550,6 +11550,14 @@ fn parse_method_expr() { | |||
| } | |||
| _ => unreachable!(), | |||
| } | |||
|
|
|||
| dialects.verified_stmt( | |||
There was a problem hiding this comment.
Can we add a scenario in the style of a::b::c().d()?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for static method invocations of data type-specific methods. For example:
SELECT geography::STGeomFromText('LINESTRING(-122.360 47.656, -122.343 47.656 )', 4326)See more here: https://learn.microsoft.com/en-us/sql/t-sql/spatial-geography/spatial-types-geography?view=sql-server-ver16