Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(deps): upgrade actions/{upload,download}-artifact@v3 to v4 #829

Merged
merged 5 commits into from
Aug 23, 2024
Merged
Show file tree
Hide file tree
Changes from 4 commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
51 changes: 33 additions & 18 deletions .github/workflows/build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ jobs:
override: true
- name: Generate license file
run: python ./dev/create_license.py
- uses: actions/upload-artifact@v3
- uses: actions/upload-artifact@v4
with:
name: python-wheel-license
path: LICENSE.txt
Expand Down Expand Up @@ -84,7 +84,7 @@ jobs:

- run: rm LICENSE.txt
- name: Download LICENSE.txt
uses: actions/download-artifact@v3
uses: actions/download-artifact@v4
with:
name: python-wheel-license
path: .
Expand All @@ -110,9 +110,9 @@ jobs:
run: find target/wheels/

- name: Archive wheels
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
with:
name: dist
name: dist-${{ matrix.os }}
path: target/wheels/*

build-macos-aarch64:
Expand Down Expand Up @@ -145,7 +145,7 @@ jobs:

- run: rm LICENSE.txt
- name: Download LICENSE.txt
uses: actions/download-artifact@v3
uses: actions/download-artifact@v4
with:
name: python-wheel-license
path: .
Expand All @@ -162,9 +162,9 @@ jobs:
run: find target/wheels/

- name: Archive wheels
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
with:
name: dist
name: dist-macos-aarch64
path: target/wheels/*

build-manylinux:
Expand All @@ -175,7 +175,7 @@ jobs:
- uses: actions/checkout@v4
- run: rm LICENSE.txt
- name: Download LICENSE.txt
uses: actions/download-artifact@v3
uses: actions/download-artifact@v4
with:
name: python-wheel-license
path: .
Expand All @@ -191,9 +191,9 @@ jobs:
rustup-components: rust-std rustfmt # Keep them in one line due to https://github.com/PyO3/maturin-action/issues/153
args: --release --manylinux 2014 --features protoc,substrait
- name: Archive wheels
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
with:
name: dist
name: dist-manylinux
Michael-J-Ward marked this conversation as resolved.
Show resolved Hide resolved
path: target/wheels/*

build-manylinux-aarch64:
Expand All @@ -204,7 +204,7 @@ jobs:
- uses: actions/checkout@v4
- run: rm LICENSE.txt
- name: Download LICENSE.txt
uses: actions/download-artifact@v3
uses: actions/download-artifact@v4
with:
name: python-wheel-license
path: .
Expand All @@ -221,9 +221,9 @@ jobs:
rustup-components: rust-std rustfmt # Keep them in one line due to https://github.com/PyO3/maturin-action/issues/153
args: --release --features protoc,substrait
- name: Archive wheels
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
with:
name: dist
name: dist-manylinux-aarch64
path: target/wheels/*

build-sdist:
Expand All @@ -234,7 +234,7 @@ jobs:
- uses: actions/checkout@v4
- run: rm LICENSE.txt
- name: Download LICENSE.txt
uses: actions/download-artifact@v3
uses: actions/download-artifact@v4
with:
name: python-wheel-license
path: .
Expand All @@ -247,18 +247,33 @@ jobs:
rustup-components: rust-std rustfmt
args: --release --sdist --out dist --features protoc,substrait
- name: Archive wheels
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
with:
name: dist
name: dist-sdist
path: target/wheels/*


merge-build-artifacts:
runs-on: ubuntu-latest
needs:
- build-python-mac-win
- build-macos-aarch64
- build-manylinux
- build-manylinux-aarch64
- build-sdist
steps:
- name: Merge Build Artifacts
uses: actions/upload-artifact/merge@v4
with:
name: dist
pattern: dist-*

# NOTE: PyPI publish needs to be done manually for now after release passed the vote
# release:
# name: Publish in PyPI
# needs: [build-manylinux, build-python-mac-win]
# runs-on: ubuntu-latest
# steps:
# - uses: actions/download-artifact@v3
# - uses: actions/download-artifact@v4
# - name: Publish to PyPI
# uses: pypa/gh-action-pypi-publish@master
# with:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/conda.yml
Original file line number Diff line number Diff line change
Expand Up @@ -101,7 +101,7 @@ jobs:
run: |
conda mambabuild --test packages/${{ matrix.arch }}/*.tar.bz2
- name: Upload conda packages as artifacts
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
with:
name: "conda nightlies (python - ${{ matrix.python }}, arch - ${{ matrix.arch }})"
# need to install all conda channel metadata to properly install locally
Expand Down
Loading