Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix: Calling count with None arguments #768

Merged
merged 2 commits into from
Aug 1, 2024
Merged

Bugfix: Calling count with None arguments #768

merged 2 commits into from
Aug 1, 2024

Commits on Jul 24, 2024

  1. Small bugfix. When arguments are None, we should use count_star

    @timsaucer
    timsaucer committed Jul 24, 2024
    Configuration menu
    Copy the full SHA
    5cabf83 View commit details
    Browse the repository at this point in the history

Commits on Jul 25, 2024

  1. When no arguments are given to count, set argument to lit(1) so that … 

    …it is similar to count_star but still enables you to select distinct=True.
    @timsaucer
    timsaucer committed Jul 25, 2024
    Configuration menu
    Copy the full SHA
    1a068e0 View commit details
    Browse the repository at this point in the history