CXFXJC-47: XJC DefaultValue plugin uses JAXBElement that does not hav…

…e a default constructor
apache · Jun 7, 2024 · df57515 · df57515
1 parent 1d98bc4
commit df57515
Show file tree

Hide file tree

Showing 2 changed files with 30 additions and 2 deletions.
diff --git a/dv-test/src/test/resources/schemas/configuration/foo.xsd b/dv-test/src/test/resources/schemas/configuration/foo.xsd
@@ -147,5 +147,21 @@
       <xs:sequence>
         <xs:element minOccurs="0" name="redemptionNumber" type="xs:string" />
       </xs:sequence>
-    </xs:complexType>    
+    </xs:complexType>
+
+    <xs:element name="vehicle" type="tns:vehicle"/>
+    <xs:complexType name="vehicle" abstract="true"/>
+
+    <xs:complexType name="car">
+        <xs:complexContent>
+            <xs:extension base="tns:vehicle"/>
+        </xs:complexContent>
+    </xs:complexType>
+    <xs:element name="car" type="tns:car" substitutionGroup="tns:vehicle"/>
+
+    <xs:complexType name="trip">
+        <xs:sequence>
+            <xs:element ref="tns:vehicle"/>
+        </xs:sequence>
+    </xs:complexType>
 </xs:schema>
diff --git a/dv/src/main/java/org/apache/cxf/xjc/dv/DefaultValuePlugin.java b/dv/src/main/java/org/apache/cxf/xjc/dv/DefaultValuePlugin.java
@@ -21,7 +21,10 @@
 
 import java.io.IOException;
 import java.lang.reflect.Field;
+import java.util.Arrays;
+import java.util.HashSet;
 import java.util.List;
+import java.util.Set;
 import java.util.logging.Level;
 import java.util.logging.Logger;
 
@@ -73,6 +76,15 @@
 public class DefaultValuePlugin {
 
     private static final Logger LOG = Logger.getLogger(DefaultValuePlugin.class.getName()); //NOPMD
+
+    // Known JAXB / JAXWS classes that do not have default constructors.
+    private static final Set<String> KNOWN_NO_DV_CLASSES = new HashSet<>(
+            Arrays.asList(
+                "jakarta.xml.ws.wsaddressing.W3CEndpointReference",
+                "jakarta.xml.bind.JAXBElement"
+            )
+        );
+
     private boolean complexTypes;
     private boolean active;
 
@@ -204,7 +216,7 @@ public boolean run(Outline outline, Options opt, ErrorHandler errorHandler) {
                     String varName = f.getPropertyInfo().getName(false);
                     JFieldVar var = co.implClass.fields().get(varName);
                     final JType rawType = f.getRawType();
-                    if (var != null && !"jakarta.xml.ws.wsaddressing.W3CEndpointReference".equals(rawType.fullName())) {
+                    if (var != null && !KNOWN_NO_DV_CLASSES.contains(rawType.erasure().fullName())) {
                         if (rawType instanceof JClass) {
                             final JClass jclazz = (JClass) rawType;
                             if (!jclazz.isAbstract() && !jclazz.isInterface()) {