Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Persistent transparency + getStatusBarHeight method #96

Closed
wants to merge 2 commits into from

Conversation

aszmyd
Copy link

@aszmyd aszmyd commented Mar 26, 2018

Platforms affected

Android

What does this PR do?

  1. It makes statusbar transparency persisten. Earlier when you call methods in this order: overlaysWebView(true) , hide() , show() the status bar gets shown without transparency and pushes webview to bottom. And because we wanted to have statusbar transparent (overlaysWebView) from this point the show/hide should toggle the statusbar visibility and it should always show transparent.
  2. Support for StatusBarOverlaysWebView in Android when its pre-defined in project config.xml
  3. Added StatusBar.getStatusBarHeight method (Android only) that gets current statusbar height in CSS pixels

What testing has been done on this change?

Manual testing on Android device

aszmyd added 2 commits March 26, 2018 14:08
…tus bar again + support pre-configured `StatusBarOverlaysWebView` parameter from `config.xml`
@Exilz
Copy link

Exilz commented Jul 4, 2018

I can confirm your getStatusBarHeight method works. Thanks a lot.

By the way, setting StatusBarOverlaysWebView to false by default solved a problem for us.

We noticed that if we changed this value to false programmatically, the height of the webview was offset by the height of the statusbar which led to the bottom content being cropped.

Please merge this Apache. This is great work.

@janpio
Copy link
Member

janpio commented Jul 18, 2018

Hey @aszmyd , this looks like a great PR. Could you maybe invest the time to make separate PRs for the separate features? Would be much easier to merge and be sure that stuff can be undone if needed.

@Exilz Thanks for your comment. The commit you linked to, is this fixing a bug that is currently present? Should there be a PR for this plugin that adopts these changes? If so, would you be kind enough to create one? Thanks!

@aszmyd
Copy link
Author

aszmyd commented Jul 18, 2018

@janpio here you go: #99 and #98

@aszmyd
Copy link
Author

aszmyd commented Jul 18, 2018

I'm closing this one as two separate PR has been made for it.

@aszmyd aszmyd closed this Jul 18, 2018
@aszmyd aszmyd deleted the persistent-transparency branch July 18, 2018 11:29
@aszmyd aszmyd restored the persistent-transparency branch July 18, 2018 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants