Update StatusBar.java #142
Conversation
|
Can you please provide some context for this change? |
|
Parameter StatusBarOverlaysWebView for android not working |
|
Just want to make a point that the docs currently states this defaults to true, but obviously doing so may break apps that depends on the android's broken result, ie no status bar overlay by default) |
There was a problem hiding this comment.
Thanks a lot for your PR!
I'd like to discuss the intended default behavior with other members, though. (Thanks @breautek for the hint with the docs).
Calling some random ppl: @janpio, @dpogue, @jcesarmobile - what's your opinion on this?
| @@ -105,6 +108,8 @@ public void run() { | |||
| // CB-11197 We still need to update LayoutParams to force status bar | |||
| // to be hidden when entering e.g. text fields | |||
| window.clearFlags(WindowManager.LayoutParams.FLAG_FULLSCREEN); | |||
|
|
|||
| setStatusBarTransparent(true); | |||
There was a problem hiding this comment.
Is this line related to the bug #151 or unrelated?
| @@ -64,6 +64,9 @@ public void run() { | |||
|
|
|||
| // Read 'StatusBarStyle' from config.xml, default is 'lightcontent'. | |||
| setStatusBarStyle(preferences.getString("StatusBarStyle", "lightcontent")); | |||
|
|
|||
| // Read 'StatusBarOverlaysWebView' from config.xml, default is false. | |||
| setStatusBarTransparent(preferences.getBoolean("StatusBarOverlaysWebView", false)); | |||
There was a problem hiding this comment.
While the default is broken, I'd rather fix the bug in the way that it corresponds with the docs, i.e., true.
|
When this PR will be done ? |
|
Closing due to inactivity and we've merged in #171 which correctly reads the variable as true, like it's stated. Nevertheless, thanks for your contribution and bringing this to our attention! |
Read 'StatusBarOverlaysWebView' from config.xml, default is false.setStatusBarTransparent(preferences.getBoolean("StatusBarOverlaysWebView", false));