feat(windows)!: remove platform support #96
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
breautek
force-pushed
the
remove-windows
branch
2 times, most recently
from
f5d6a2b to
0269fd1
Compare
erisu
approved these changes
Jul 4, 2024
jcesarmobile
approved these changes
Jul 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Platforms affected
Windows
Motivation and Context
Windows platform has been deprecated so now it's a good opportunity of dropping support in the device motion plugin for the major "undeprecating" release.
Depends on #95
Description
Removed windows related code, the windows check in tests, and all other references to the windows platform.
Testing
Ran npm test
Checklist
(platform)if this change only applies to one platform (e.g.(android))