Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): Update some dependencies, add Node 20 to CI #924

Merged
merged 2 commits into from
Apr 17, 2024

Conversation

dpogue
Copy link
Member

@dpogue dpogue commented Apr 16, 2024

Platforms affected

All

Motivation and Context

Keep things up to date and resolve some npm audit warnings about dependencies.

Description

  • Rebuild package-lock.json with updated dependencies
  • Drop pify, delay, and fs-extra dependencies
  • Migrate from fs-extra APIs to built-in NodeJS fs APIs
  • Minor cleanups of some CodeQL-identified syntax errors in dummy test files
  • Update GitHub Actions steps to latest versions
  • Add CodeQL scanning as part of CI
  • Add Node 20 to CI matrix

Testing

  • All unit and integration tests pass locally and in CI

Checklist

  • I've run the tests to see all new and existing tests pass

@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

@codecov-commenter
Copy link

codecov-commenter commented Apr 16, 2024

Codecov Report

Attention: Patch coverage is 91.95402% with 7 lines in your changes missing coverage. Please review.

Project coverage is 87.92%. Comparing base (66c9670) to head (90da6e5).
Report is 3 commits behind head on master.

Files with missing lines Patch % Lines
src/plugman/init-defaults.js 0.00% 3 Missing ⚠️
src/plugman/platform.js 50.00% 2 Missing ⚠️
src/plugman/fetch.js 92.85% 1 Missing ⚠️
src/plugman/install.js 85.71% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master     #924   +/-   ##
=======================================
  Coverage   87.92%   87.92%           
=======================================
  Files          46       46           
  Lines        2129     2129           
=======================================
  Hits         1872     1872           
  Misses        257      257           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@erisu erisu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dpogue dpogue merged commit 18113b4 into apache:master Apr 17, 2024
10 checks passed
@dpogue dpogue deleted the deps-202404 branch April 17, 2024 02:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants