Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix:update insight to support macOS 12 monterey #567

Closed
wants to merge 1 commit into from

Conversation

yeli19950109
Copy link

@yeli19950109 yeli19950109 commented Dec 1, 2021

update insight version

Platforms affected

macos 12+

Motivation and Context

#566

Description

support macOS 12 monterey

Testing

Checklist

  • I've run the tests to see all new and existing tests pass
  • I added automated test coverage as appropriate for this change
  • Commit is prefixed with (platform) if this change only applies to one platform (e.g. (android))
  • If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct keyword to close issues using keywords)
  • I've updated the documentation if necessary

update insight version
@yeli19950109 yeli19950109 changed the title fix:support macOS 12 monterey fix:update insight to support macOS 12 monterey Dec 1, 2021
@erisu erisu closed this in #573 Dec 17, 2021
@erisu
Copy link
Member

erisu commented Dec 17, 2021

Thank you for your PR and work.

I went ahead and merged in #573 which updated the insight dependency but also updated the package-lock.json and code usage that this PR was missing. There was a breaking change in the update that this PR was not handling.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants