-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CRYPTO-161 Add SM4 encryption support #161
base: master
Are you sure you want to change the base?
Conversation
Hi, I am interested in the work, that you are doing here. Question: I notice, that your patch provides changes in the native code. That makes me hesitant: Before I accept the PR, could you help me to setup a build environment, where I can test these changes. Background: We are considering a new release. As of now, there are no changes in the native code, so we could (in theory) just copy the native files from the previous release. But, for a release, that includes this PR, we would need a running build environment, where we can produce the updated files. If this is interesting to you, please contact me privately at [email protected]. Thanks, Jochen |
We really need to update our GitHub build to deal with the C sources... |
We need to be able to tell GitHub builds that we need OpenSSL >= 1.1.1 |
I found a warning in Java CI / build (macos-latest, 8, false): Maybe the OpenSSL in Github builds is 1.0.0 |
Welcome to Codecov 🎉Once merged to your default branch, Codecov will compare your coverage reports and display the results in this comment. Thanks for integrating Codecov - We've got you covered ☂️ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look fine; however there are no tests
add sm4-ctr and sm4-cbc in opensslCipher