linstor/kvm: Workaround a qemu bug and IDE bus discard enabled.

[rp-]

Description

qemu has a bug versions prior 7.0 with discard enabled and using the IDE bus.
It would crash the qemu process and kill the virtual machine, this is most noticeable on installing a windows guest from the Windows ISO installer.

bug link:
https://bugzilla.redhat.com/show_bug.cgi?id=2029980

Types of changes

• Breaking change (fix or feature that would cause existing functionality to change)
• New feature (non-breaking change which adds functionality)
• Bug fix (non-breaking change which fixes an issue)
• Enhancement (improves an existing feature and functionality)
• Cleanup (Code refactoring and cleanup, that may add test cases)
• build/CI
• test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

• Major
• Minor

Bug Severity

• BLOCKER
• Critical
• Major
• Minor
• Trivial

Screenshots (if appropriate):

How Has This Been Tested?

Tested in a local Linstor cluster and added unittests to check the combinations.

How did you try to break this feature and the system with this change?

[rp-]

@JoaoJandre As the Linstor discard support was included in 4.20/main,
I appreciate it if you would also think about get this included.

[codecov]

Codecov Report

Attention: Patch coverage is 66.66667% with 2 lines in your changes missing coverage. Please review.

Project coverage is 15.10%. Comparing base (175eed2) to head (393ae8f).
Report is 1 commits behind head on 4.19.

Files with missing lines	Patch %	Lines
...ervisor/kvm/resource/LibvirtComputingResource.java	80.00%	0 Missing and 1 partial ⚠️
...ud/hypervisor/kvm/storage/KVMStorageProcessor.java	0.00%	1 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff              @@
##               4.19    #9859      +/-   ##
============================================
+ Coverage     15.08%   15.10%   +0.01%     
- Complexity    11203    11214      +11     
============================================
  Files          5404     5404              
  Lines        473423   473426       +3     
  Branches      59987    60199     +212     
============================================
+ Hits          71429    71524      +95     
+ Misses       394044   393908     -136     
- Partials       7950     7994      +44     

Flag	Coverage Δ
uitests	4.30% <ø> (ø)
unittests	15.82% <66.66%> (+0.02%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[JoaoJandre]

@rp- Yes, we can add it to 4.20

[JoaoJandre]

@blueorangutan package

[blueorangutan]

@JoaoJandre a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[blueorangutan]

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 11470

[DaanHoogland]

@blueorangutan test

[blueorangutan]

@DaanHoogland a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

[sureshanaparti]

clgtm

[blueorangutan]

[SF] Trillian Build Failed (tid-11726)

[slavkap]

CLGTM

[blueorangutan]

[SF] Trillian test result (tid-11727)
Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8
Total time taken: 43374 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr9859-t11727-kvm-ol8.zip
Smoke tests completed. 133 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File

[blueorangutan]

[SF] Trillian test result (tid-11734)
Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8
Total time taken: 45552 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr9859-t11734-kvm-ol8.zip
Smoke tests completed. 133 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File