Revert "storage: fix private templates are not copied to new image store (#9206)"

[weizhouapache]

Description

This reverts commit e06f80e.

I have discussed with @NuxRo @rajujith @alexandremattioli , it seems it is expected that private template has only 1 copy on the secondary storages.

we all agreed that it should be improved as the template with 1 copy becomes unavailable if the secondary storage is removed.
ideally there is a global setting to specify the minimum number of copies on secondary storages.

Types of changes

• Breaking change (fix or feature that would cause existing functionality to change)
• New feature (non-breaking change which adds functionality)
• Bug fix (non-breaking change which fixes an issue)
• Enhancement (improves an existing feature and functionality)
• Cleanup (Code refactoring and cleanup, that may add test cases)
• build/CI
• test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

• Major
• Minor

Bug Severity

• BLOCKER
• Critical
• Major
• Minor
• Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

[codecov]

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 15.08%. Comparing base (175eed2) to head (0319275).

Files with missing lines	Patch %	Lines
.../cloudstack/storage/image/TemplateServiceImpl.java	0.00%	3 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff              @@
##               4.19    #9839      +/-   ##
============================================
- Coverage     15.08%   15.08%   -0.01%     
+ Complexity    11203    11202       -1     
============================================
  Files          5404     5404              
  Lines        473423   473426       +3     
  Branches      59987    60080      +93     
============================================
- Hits          71429    71426       -3     
- Misses       394044   394050       +6     
  Partials       7950     7950              

Flag	Coverage Δ
uitests	4.30% <ø> (ø)
unittests	15.80% <0.00%> (-0.01%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[rajujith]

@blueorangutan package

[blueorangutan]

@rajujith a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[blueorangutan]

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 11414

[rajujith]

LGTM

[DaanHoogland]

clgtm, functionality seems off a bit. (not a -1!)