pre-commit: enable markdownlint rule MD018

[jbampton]

https://github.com/DavidAnson/markdownlint/blob/main/doc/md018.md

Description

This PR adds another check for our Markdown linter.

MD018/no-missing-space-atx No space after hash on atx style heading.

Types of changes

• Breaking change (fix or feature that would cause existing functionality to change)
• New feature (non-breaking change which adds functionality)
• Bug fix (non-breaking change which fixes an issue)
• Enhancement (improves an existing feature and functionality)
• Cleanup (Code refactoring and cleanup, that may add test cases)
• build/CI

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

• Major
• Minor

Bug Severity

• BLOCKER
• Critical
• Major
• Minor
• Trivial

Screenshots (if appropriate):

How Has This Been Tested?

Ran locally:

pre-commit run --all-files

How did you try to break this feature and the system with this change?

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 15.78%. Comparing base (554ea22) to head (009ed10).
Report is 12 commits behind head on main.

Additional details and impacted files

@@             Coverage Diff              @@
##               main    #9134      +/-   ##
============================================
- Coverage     16.60%   15.78%   -0.83%     
- Complexity    12565    12613      +48     
============================================
  Files          5235     5627     +392     
  Lines        460072   494665   +34593     
  Branches      56928    61938    +5010     
============================================
+ Hits          76408    78091    +1683     
- Misses       375338   408082   +32744     
- Partials       8326     8492     +166     

Flag	Coverage Δ
uitests	4.04% <ø> (?)
unittests	16.60% <ø> (-0.01%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[jbampton]

@blueorangutan package

[blueorangutan]

@jbampton a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[blueorangutan]

Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 10276

[jbampton]

@blueorangutan package

[blueorangutan]

@jbampton a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[blueorangutan]

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 11335

[DaanHoogland]

clgtm

[vishesh92]

lgtm

[DaanHoogland]

@JoaoJandre , can we merge these linting changes (mostly by @jbampton ) during freeze? I don't think any of them have code changes. At least this one hasn't .

[JoaoJandre]

@JoaoJandre , can we merge these linting changes (mostly by @jbampton ) during freeze? I don't think any of them have code changes. At least this one hasn't .

@DaanHoogland I don't see why we would merge them during a freeze. Although they generally do not pose any risks (at least this one doesn't), they are also not really high priority, are they? I see no problem in waiting until we release to merge these.