Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Force some param to be required #79

Merged
merged 2 commits into from
Mar 12, 2024
Merged

Force some param to be required #79

merged 2 commits into from
Mar 12, 2024

Conversation

vishesh92
Copy link
Member

@weizhouapache
Copy link
Member

good job ! @vishesh92

@weizhouapache
Copy link
Member

@vishesh92
there are some more params in @shwstppr 's PR #77

@vishesh92
Copy link
Member Author

I will create a separate PR for the remaining params from #77 . Some of them needs a discussion.

weizhouapache
weizhouapache approved these changes Mar 7, 2024
View reviewed changes
Copy link
Member

@weizhouapache weizhouapache left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code lgtm

@shwstppr
Copy link
Contributor

Merging based on approvals

@shwstppr shwstppr merged commit dd1ad53 into apache:main Mar 12, 2024
1 check passed
@shwstppr shwstppr mentioned this pull request Mar 15, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@weizhouapache weizhouapache weizhouapache approved these changes

@rohityadavcloud rohityadavcloud rohityadavcloud approved these changes

Assignees

@shwstppr shwstppr

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@vishesh92 @weizhouapache @shwstppr @rohityadavcloud