Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update documentation for importing of instances #453

Merged
merged 11 commits into from
Nov 29, 2024
Merged

Update documentation for importing of instances #453

merged 11 commits into from
Nov 29, 2024

Conversation

vishesh92
Copy link
Member

@vishesh92 vishesh92 commented Nov 5, 2024 •
edited by github-actions bot
Loading

@vishesh92 vishesh92 mentioned this pull request Nov 5, 2024
Merged
9 tasks
@andrijapanicsb
Copy link
Contributor

@vishesh92 the other doc PR is for a feature scheduled for 4.20.1 - so not sure this doc PR should wait for that other one ?

@vishesh92
Copy link
Member Author

@vishesh92 the other doc PR is for a feature scheduled for 4.20.1 - so not sure this doc PR should wait for that other one ?

@andrijapanicsb Which PR do you mean? The feature change PR is opened against 4.19 branch as of now.

@andrijapanicsb
Copy link
Contributor

If not mistaken, this doc PR should be in here for 4.19.x.x branch, while the other PR (that you said we need to wait for, in the desc of this PR) - apache/cloudstack#9787 - is planned for 4.20.1 (far future).

This PR (453) we need merged already, afaik and should be part of the official 4.19.1.1+ releases.

Or am I wrong @vishesh92

kiranchavala
kiranchavala reviewed Nov 13, 2024
View reviewed changes
Copy link
Contributor

@kiranchavala kiranchavala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vishesh92

Looks like the formatting is not proper, can you divide it into smaller bullet points or paragraphs.

Also, can you mention the disabled clusters / or hosts which are not enabled or in maintenance mode are not supported for importing vm's

Screenshot 2024-11-13 at 12 35 23 PM

@vishesh92
Copy link
Member Author

If not mistaken, this doc PR should be in here for 4.19.x.x branch, while the other PR (that you said we need to wait for, in the desc of this PR) - apache/cloudstack#9787 - is planned for 4.20.1 (far future).

This PR (453) we need merged already, afaik and should be part of the official 4.19.1.1+ releases.

Or am I wrong @vishesh92

@andrijapanicsb Both the PRs are against 4.19 branch.

@kiranchavala
Copy link
Contributor

@blueorangutan docbuild

@blueorangutan
Copy link

@kiranchavala a Jenkins job has been kicked to build the document. I'll keep you posted as I make progress.

@vishesh92 @sureshanaparti
Apply suggestions from code review
f304040 
Co-authored-by: Suresh Kumar Anaparti <[email protected]>
@sureshanaparti
Copy link
Contributor

@blueorangutan docbuild

@blueorangutan
Copy link

@sureshanaparti a Jenkins job has been kicked to build the document. I'll keep you posted as I make progress.

@sureshanaparti sureshanaparti added this to the 4.19.2 milestone Nov 13, 2024
@andrijapanicsb
Copy link
Contributor

@blueorangutan docbuild

@blueorangutan
Copy link

@andrijapanicsb a Jenkins job has been kicked to build the document. I'll keep you posted as I make progress.

@blueorangutan
Copy link

QA-Doc build preview: https://qa.cloudstack.cloud/builds/docs-build/pr/453. (QA-JID 285)

@andrijapanicsb
Copy link
Contributor

@vishesh92 please see my comments in this page.

@vishesh92
Copy link
Member Author

@vishesh92 please see my comments in this page.

Your changes looks good.

@vishesh92 vishesh92 marked this pull request as ready for review November 18, 2024 04:55
@vishesh92
Copy link
Member Author

@blueorangutan docbuild

@blueorangutan
Copy link

@vishesh92 a Jenkins job has been kicked to build the document. I'll keep you posted as I make progress.

@blueorangutan
Copy link

QA-Doc build preview: https://qa.cloudstack.cloud/builds/docs-build/pr/453. (QA-JID 288)

@andrijapanicsb
Copy link
Contributor

@blueorangutan docbuild

@blueorangutan
Copy link

@andrijapanicsb a Jenkins job has been kicked to build the document. I'll keep you posted as I make progress.

@blueorangutan
Copy link

QA-Doc build preview: https://qa.cloudstack.cloud/builds/docs-build/pr/453. (QA-JID 289)

@andrijapanicsb
Copy link
Contributor

@blueorangutan docbuild

@blueorangutan
Copy link

@andrijapanicsb a Jenkins job has been kicked to build the document. I'll keep you posted as I make progress.

@blueorangutan
Copy link

QA-Doc build preview: https://qa.cloudstack.cloud/builds/docs-build/pr/453. (QA-JID 290)

@andrijapanicsb
Copy link
Contributor

@blueorangutan docbuild

@blueorangutan
Copy link

@andrijapanicsb a Jenkins job has been kicked to build the document. I'll keep you posted as I make progress.

@blueorangutan
Copy link

QA-Doc build preview: https://qa.cloudstack.cloud/builds/docs-build/pr/453. (QA-JID 291)

@andrijapanicsb
Copy link
Contributor

@vishesh92 this should be good for merging

@andrijapanicsb andrijapanicsb self-requested a review November 28, 2024 12:44
@DaanHoogland DaanHoogland merged commit 3e82814 into apache:4.19 Nov 29, 2024
1 check passed
@vishesh92 vishesh92 deleted the allow-import-via-another-host branch November 29, 2024 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sureshanaparti sureshanaparti sureshanaparti left review comments

@kiranchavala kiranchavala kiranchavala left review comments

@andrijapanicsb andrijapanicsb andrijapanicsb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
4.19.2
Development

Successfully merging this pull request may close these issues.
6 participants
@vishesh92 @andrijapanicsb @kiranchavala @blueorangutan @sureshanaparti @DaanHoogland