Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add build job for dev container (and small fixes) #717

Merged
merged 5 commits into from
Jan 8, 2024
Merged

Add build job for dev container (and small fixes) #717

merged 5 commits into from
Jan 8, 2024

Commits on Jan 7, 2024

  1. container: Remove incorrect comment in Gitpod container

    @rlenferink
    rlenferink committed Jan 7, 2024
    Configuration menu
    Copy the full SHA
    7e050ed View commit details
    Browse the repository at this point in the history

  2. container: Rename 'start' script to 'run' script 

    This matches more with the concept of passing custom commands, where a container can be started and exited
    @rlenferink
    rlenferink committed Jan 7, 2024
    Configuration menu
    Copy the full SHA
    2fa0830 View commit details
    Browse the repository at this point in the history

  3. container: Update README to advise using 'build' directory 

    This because:
* The 'build' directory is already ignored in the .gitignore
* The 'build' directory is used in other examples on the Celix website
    @rlenferink
    rlenferink committed Jan 7, 2024
    Configuration menu
    Copy the full SHA
    99e9b7b View commit details
    Browse the repository at this point in the history

  4. container: Fix variable globbing in run script 

    This allows to execute chained commands. For example:
./run-ubuntu-container.sh "mkdir -p build && cd build && ../container/support-scripts/build-all.sh && make -j"
    @rlenferink
    rlenferink committed Jan 7, 2024
    Configuration menu
    Copy the full SHA
    171db15 View commit details
    Browse the repository at this point in the history

  5. container: Add container build workflow

    @rlenferink
    rlenferink committed Jan 7, 2024
    Configuration menu
    Copy the full SHA
    d99179a View commit details
    Browse the repository at this point in the history