Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CELEBORN-1621][CIP-11] Predefined worker tags expr via dynamic configs #2936

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

s0nskar
Copy link
Contributor

@s0nskar s0nskar commented Nov 21, 2024

What changes were proposed in this pull request?

Support predefined tags expression for tenant and users via dynamic config. Using this admin can configure tags for users/tenants and give permission to special users to provide custom tags expression.

Why are the changes needed?

https://cwiki.apache.org/confluence/display/CELEBORN/CIP-11+Supporting+Tags+in+Celeborn

Does this PR introduce any user-facing change?

NA

How was this patch tested?

UTs

@s0nskar s0nskar marked this pull request as ready for review November 21, 2024 12:36
@s0nskar
Copy link
Contributor Author

s0nskar commented Nov 25, 2024

Test failures seems unrelated.

@FMX
Copy link
Contributor

FMX commented Nov 25, 2024

I'll review this PR within this week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants