-
Notifications
You must be signed in to change notification settings - Fork 361
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CELEBORN-1700] Flink supports fallback to vanilla Flink built-in shuffle implementation #2932
Open
SteNicholas
wants to merge
1
commit into
apache:main
Choose a base branch
from
SteNicholas:CELEBORN-1700
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SteNicholas
force-pushed
the
CELEBORN-1700
branch
from
November 20, 2024 15:12
bb83198
to
85d5429
Compare
SteNicholas
force-pushed
the
CELEBORN-1700
branch
from
November 20, 2024 16:03
85d5429
to
6321ad8
Compare
Ping @reswqa, @codenohup, @RexXiong. |
codenohup
reviewed
Nov 21, 2024
.../common/src/main/java/org/apache/celeborn/plugin/flink/AbstractRemoteShuffleEnvironment.java
Show resolved
Hide resolved
reswqa
reviewed
Nov 21, 2024
common/src/main/scala/org/apache/celeborn/common/CelebornConf.scala
Outdated
Show resolved
Hide resolved
.../src/main/java/org/apache/celeborn/plugin/flink/fallback/WorkersAvailableFallbackPolicy.java
Show resolved
Hide resolved
SteNicholas
force-pushed
the
CELEBORN-1700
branch
from
November 22, 2024 03:13
6321ad8
to
1f57391
Compare
…ffle implementation
SteNicholas
force-pushed
the
CELEBORN-1700
branch
from
November 22, 2024 03:28
1f57391
to
dfc93da
Compare
reswqa
approved these changes
Nov 22, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the update, LGTM.
codenohup
approved these changes
Nov 22, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for your contribution!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Flink supports fallback to vanilla Flink built-in shuffle implementation.
Why are the changes needed?
When quota is unenough or workers are unavailable,
RemoteShuffleMaster
does not support fallback toNettyShuffleMaster
, andRemoteShuffleEnvironment
does not support fallback toNettyShuffleEnvironment
at present. Flink should support fallback to vanilla Flink built-in shuffle implementation for unenough quota and unavailable workers.Does this PR introduce any user-facing change?
ShuffleFallbackPolicy
interface to determine whether fallback to vanilla Flink built-in shuffle implementation.celeborn.client.flink.shuffle.fallback.policy
config to support shuffle fallback policy configuration.How was this patch tested?
WordCountTestBase#celeborn flink integration test with fallback - word count