C19288 accord async reads are unsafe #98
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dcapwell
reviewed
Jun 15, 2024
| SafeCommand safeCommand = in.ifInitialised(txnId); | ||
| if (safeCommand != null) safeCommand.removeListener(this); | ||
| }, node.agent())); | ||
| if (waitingOn != null) |
There was a problem hiding this comment.
did you hit a NPE? since we touch waitingOn.stream() we would hit a NPE.
There was a problem hiding this comment.
yes, if there are multiple calls to cancel it will throw an NPE
dcapwell
reviewed
Jun 15, 2024
|
I think that async reads are safe by virtue of the execution process, but the assertion was assuming they were synchronous. Was there another issue with ephemeral reads? I'm less familiar with them, but it seems like it would be ok for an ephemeral read to read the from "future", so long as they don't go backwards in time |
|
We disable Ephemeral Reads in C* as they don't work (let alone a single cache evict will cause chaos), so thats fine by me. |
belliottsmith
force-pushed
the
trunk
branch
2 times, most recently
from
6a9482b
to
4a8566a
Compare
belliottsmith
force-pushed
the
trunk
branch
6 times, most recently
from
1f18dbd
to
70e61b4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.