CASSANDRA-19355: Refactort CommandsForRange to work based off disk state rather than in-memory state #83
Conversation
| { | ||
| int domainSize = (maxExclusive - minInclusive + 1); | ||
| if (domainSize < 0) | ||
| throw new IllegalArgumentException("Range is too large; min=" + minInclusive + ", max=" + maxExclusive); |
There was a problem hiding this comment.
I could support but figured its best to keep this logic simpler until thats needed... if you want mixDistribution(Long.MIN_VALUE, Long.MAX_VALUE) we need BigInteger to handle this...
| int[] array, indexes; | ||
| if (domainSize > 200) // randomly selected | ||
| { | ||
| int numBuckets = 10; |
There was a problem hiding this comment.
when it comes to randomWeight and zipF having larger arrays doesn't make too much sense, so this puts a bias into a smaller array and generates values within that section of the range.
I could make this a config, but I didn't need so can refactor later if needed
|
|
||
| import static accord.utils.Property.qt; | ||
|
|
||
| class SearchableRangeListTest |
There was a problem hiding this comment.
this is kinda duplicated in org.apache.cassandra.utils.RTreeTest#test but has better coverage... I wrote this class first and feel its always best to have tests at this level / project rather than depending on the C* test...
| @@ -29,7 +29,7 @@ repositories { | |||
| } | |||
|
|
|||
| compileJava { | |||
| sourceCompatibility = JavaVersion.VERSION_1_8 | |||
| sourceCompatibility = JavaVersion.VERSION_11 | |||
There was a problem hiding this comment.
we actually don't compile on jdk8... so this just makes it so we can use JDK 11 features again
dcapwell
force-pushed
the
CASSANDRA-19355
branch
from
8d6d81c
to
c4dedec
Compare
dcapwell
force-pushed
the
CASSANDRA-19355
branch
from
c4dedec
to
fa75412
Compare
belliottsmith
force-pushed
the
trunk
branch
2 times, most recently
from
6a9482b
to
4a8566a
Compare
belliottsmith
force-pushed
the
trunk
branch
6 times, most recently
from
1f18dbd
to
70e61b4
Compare
No description provided.