CASSANDRA-19975: to make MixedTopologyTest stable we need to know the topology to make sure each change is safe #129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dcapwell
commented
Oct 2, 2024
| @@ -467,6 +480,7 @@ public <State, SystemUnderTest> void check(Commands<State, SystemUnderTest> comm | |||
| } | |||
| commands.destroySut(sut, null); | |||
| commands.destroyState(state, null); | |||
| commands.onSuccess(state, sut, history); | |||
There was a problem hiding this comment.
the test now logs the history for each seed, just for extra logging... I kept putting a break point to see this information
dcapwell
commented
Oct 2, 2024
| @@ -837,6 +860,18 @@ public CommandsBuilder<State, SystemUnderTest> unknownWeight(Gen.IntGen unknownW | |||
| return this; | |||
| } | |||
|
|
|||
| public CommandsBuilder<State, SystemUnderTest> commandsTransformer(BiFunction<State, Gen<Command<State, SystemUnderTest, ?>>, Gen<Command<State, SystemUnderTest, ?>>> commandsTransformer) | |||
There was a problem hiding this comment.
this is to move the hidden changes we do and push them into the history. stuff like changing replication favor is now going to show up in the history
belliottsmith
force-pushed
the
trunk
branch
2 times, most recently
from
6a9482b
to
4a8566a
Compare
dcapwell
force-pushed
the
CASSANDRA-19975
branch
from
eec4476
to
7380656
Compare
… topology to make sure each change is safe
…ve with stateful tests
dcapwell
force-pushed
the
CASSANDRA-19975
branch
from
7380656
to
5598bda
Compare
belliottsmith
force-pushed
the
trunk
branch
6 times, most recently
from
1f18dbd
to
70e61b4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.