-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CAMEL-21190 - Configure Maven Javadoc Plugin for Java version used for compilation #15983
base: main
Are you sure you want to change the base?
CAMEL-21190 - Configure Maven Javadoc Plugin for Java version used for compilation #15983
Conversation
compilation it requires then to not use the doclint as there are a bunch of invalid or no more valid Javadoc in the codebase Signed-off-by: Aurélien Pupier <[email protected]>
🌟 Thank you for your contribution to the Apache Camel project! 🌟 🤖 CI automation will test this PR automatically. 🐫 Apache Camel Committers, please review the following items:
|
@@ -3546,12 +3546,12 @@ | |||
<artifactId>maven-javadoc-plugin</artifactId> | |||
<configuration> | |||
<attach>true</attach> | |||
<source>${jdk.version}</source> | |||
<release>${maven.javadoc.release}</release> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If I understood well, we should be able to even not provide the release version now as it would pick it up from maven-compiler.release https://maven.apache.org/plugins/maven-javadoc-plugin/javadoc-mojo.html#release
But maybe better to keep it for now to have a finer grained control.
mvn javadoc:javadoc currently failing with:
EDIT: reproducing this erro ron main branch when setting the doclint to none too (otherwise failing sooner). So wondering how the javadoc is currently generated oO . About the error in itself the mentioned class is available in target/generated-sources but not in src/generated/sources |
Description
it requires then to not use the doclint as there are a bunch of invalid or no more valid Javadoc in the codebase.
It was already used and mentioned as a workaround for one of the configuration of the maven-javadoc-plugin:
camel/pom.xml
Line 714 in 0c63d15
reported https://issues.apache.org/jira/browse/CAMEL-21356 to fix the Javadoc issues
to test locally (at least a part of the changes), we can call
mvn javadoc:javadoc
Target
camel-3.x
, whereas Camel 4 uses themain
branch)Tracking
Apache Camel coding standards and style
mvn clean install -DskipTests
locally from root folder and I have committed all auto-generated changes.