Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CAMEL-21461: Add features to Camel Platform Http Starter #1286

Merged
merged 1 commit into from
Nov 25, 2024
Merged

CAMEL-21461: Add features to Camel Platform Http Starter #1286

merged 1 commit into from
Nov 25, 2024

Conversation

Croway
Copy link
Contributor

@Croway Croway commented Nov 18, 2024

No description provided.

@Croway Croway force-pushed the certification-test-platform-http-sb branch from 1af89d7 to e880358 Compare November 18, 2024 14:50
orpiske
orpiske reviewed Nov 18, 2024
View reviewed changes
Copy link
Contributor

@orpiske orpiske left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's on the right track. I did left a few (nitpick) suggestions.

Also, it would probably be good to get an additional review as my Spring-foo is limited.

...apache/camel/component/platform/http/springboot/SpringBootPlatformHttpCertificationTest.java Outdated Show resolved Hide resolved
...apache/camel/component/platform/http/springboot/SpringBootPlatformHttpCertificationTest.java Show resolved Hide resolved
@Croway Croway force-pushed the certification-test-platform-http-sb branch from e880358 to 42f45af Compare November 18, 2024 15:17
@Croway Croway marked this pull request as ready for review November 19, 2024 10:52
@Croway Croway requested a review from oscerd November 19, 2024 10:52
@Croway Croway force-pushed the certification-test-platform-http-sb branch 2 times, most recently from 5e757f1 to 50d6f87 Compare November 19, 2024 16:25
@Croway Croway force-pushed the certification-test-platform-http-sb branch 2 times, most recently from 1ea0751 to 5aec302 Compare November 20, 2024 09:02
davsclaus
davsclaus approved these changes Nov 25, 2024
View reviewed changes
Copy link
Contributor

@davsclaus davsclaus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work - its a lot of stuff to do to investigate and add the missing features, and find which code can be reused or not.

@Croway Croway force-pushed the certification-test-platform-http-sb branch from 013b6d9 to 88be5e1 Compare November 25, 2024 13:01
@Croway
CAMEL-21461: Add features to Platform Http SB Starter
3eba54f 
Certification Tests + Minor Fixes

Add failing tests

Add ReaderCache Converter test

fix streaming large file test

header mapping is already done in DefaultHttpBinding

fix streaming

CSB-5889: Let's cache the body so that is can be read multiple times

CSB-5889: regen

Disable not implemented feature tests

Co-Authored-By: johnpoth <[email protected]>

Handle Consumes only for methods with body
@Croway Croway force-pushed the certification-test-platform-http-sb branch from 88be5e1 to 3eba54f Compare November 25, 2024 13:02
@Croway Croway merged commit 7d7002b into apache:main Nov 25, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@orpiske orpiske orpiske left review comments

@cunningt cunningt cunningt left review comments

@johnpoth johnpoth johnpoth approved these changes

@davsclaus davsclaus davsclaus approved these changes

@oscerd oscerd Awaiting requested review from oscerd

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Croway @cunningt @davsclaus @orpiske @johnpoth