Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-44795: [C++] Use arrow::util::span<T> on BooleanBuilder APIs instead of std::vector<T>& #44813

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

raulcd
Copy link
Member

@raulcd raulcd commented Nov 22, 2024

Rationale for this change

arrow::util::span (a backport of C++20 std::span) is more generally applicable than std::vector, so any public API currently accepting a vector const-ref argument should instead accept a span argument.

What changes are included in this PR?

BooleanBuilder accepts arrow::util::span instead of std::vector on its API

Are these changes tested?

Via CI

Are there any user-facing changes?

Yes, from std::vector& to arrow::util::span.

@raulcd
Copy link
Member Author

raulcd commented Nov 22, 2024

I created a second PR to investigate further what is going on but it seems like it's not able to convert from std::vector<bool>& to arrow::util::span<bool> so there might be an issue on our implementation of arrow::util::span

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant