GH-44795: [C++] Use arrow::util::span<T> on BooleanBuilder APIs instead of std::vector<T>& #44813
+22
−23
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
arrow::util::span
(a backport of C++20std::span
) is more generally applicable thanstd::vector
, so any public API currently accepting a vector const-ref argument should instead accept a span argument.What changes are included in this PR?
BooleanBuilder
acceptsarrow::util::span
instead ofstd::vector
on its APIAre these changes tested?
Via CI
Are there any user-facing changes?
Yes, from std::vector& to arrow::util::span.
const vector<T>&
argument should instead take aspan<const T>
#44795