GH-44626: [Java] fix SplitAndTransfer throws for empty MapVector #44627
+62
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Maksim Yegorov <[email protected]>
vibhatha
reviewed
Nov 3, 2024
| final int relativeOffset = | ||
| offsetBuffer.getInt((startIndex + i) * OFFSET_WIDTH) - startPoint; | ||
| to.offsetBuffer.setInt(i * OFFSET_WIDTH, relativeOffset); | ||
| if (length > 0) { |
There was a problem hiding this comment.
can we just return if length=0
There was a problem hiding this comment.
Can do though my personal preference would be to avoid multiple returns. Current implementation is in keeping with how splitAndTransfer is implemented for other complex types (e.g. ListVector).
github-actions
bot
added
awaiting committer review
vibhatha
reviewed
Nov 3, 2024
| ListVector toListVector = (ListVector) transferPair.getTo(); | ||
|
|
||
| assertEquals(valueCount, toListVector.getValueCount()); | ||
| fromListVector.clear(); |
There was a problem hiding this comment.
nit: use try-with-resources
There was a problem hiding this comment.
Note that there're several closeable resources here and toListVector cannot be constructed inside the same try as fromListVector. This is just to say that there'd be some ugly nesting if using try.
|
@lidavidm need some help to run the CIs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Empty MapVector.splitAndTransfer throws
java.lang.IndexOutOfBoundsException. Details in #44626What changes are included in this PR?
Fixed for MapVector as for other vector types in #41066
Are these changes tested?
Added unit test mimicking the scenario we've observed where MapVector's offset buffer capacity is 0.