Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-44618: [GLib] Add GArrowDecimal64Scalar #44620

Merged
merged 1 commit into from
Nov 3, 2024

Conversation

hiroyuki-sato
Copy link
Contributor

@hiroyuki-sato hiroyuki-sato commented Nov 2, 2024

Rationale for this change

The arrow::Decimal64Scalar has been released.
GLib needs to implement GArrowDecimal64Scalar.

What changes are included in this PR?

Implement GArrowDecimal64Scalar.

Are these changes tested?

YES

Are there any user-facing changes?

NO

Copy link

github-actions bot commented Nov 2, 2024

⚠️ GitHub issue #44618 has been automatically assigned in GitHub to PR creator.

Copy link
Member

@kou kou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@kou kou merged commit a08037f into apache:main Nov 3, 2024
10 checks passed
@kou kou removed the awaiting review Awaiting review label Nov 3, 2024
@github-actions github-actions bot added the awaiting merge Awaiting merge label Nov 3, 2024
Copy link

After merging your PR, Conbench analyzed the 3 benchmarking runs that have been run so far on merge-commit a08037f.

There was 1 benchmark result indicating a performance regression:

The full Conbench report has more details. It also includes information about 2 possible false positives for unstable benchmarks that are known to sometimes produce them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants