GH-44541: [C++] NumericArray<T> should not use ctor from parent directly #44542
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
mapleFU
force-pushed
the
fix-numeric-array-ctor
branch
from
a8169c4
to
1896d63
Compare
wgtmac
reviewed
Oct 28, 2024
| @@ -119,8 +129,6 @@ class NumericArray : public PrimitiveArray { | |||
| IteratorType end() const { return IteratorType(*this, length()); } | |||
|
|
|||
| protected: | |||
| using PrimitiveArray::PrimitiveArray; | |||
There was a problem hiding this comment.
Do we need to add NumericArray() if this line is deleted?
github-actions
bot
added
awaiting committer review
wgtmac
changed the title
wgtmac
reviewed
Oct 28, 2024
| @@ -585,6 +585,18 @@ TEST_F(TestArray, TestValidateNullCount) { | |||
| } | |||
| } | |||
|
|
|||
| TEST_F(TestArray, TestValidValues) { | |||
There was a problem hiding this comment.
Should we add a test case for TimestampArray specifically?
bkietz
reviewed
Oct 28, 2024
| @@ -119,7 +129,7 @@ class NumericArray : public PrimitiveArray { | |||
| IteratorType end() const { return IteratorType(*this, length()); } | |||
|
|
|||
| protected: | |||
There was a problem hiding this comment.
The use of protected is odd here; nothing inherits from NumericArray inside arrow. Is it intended to support user subclassing of NumericArray? Or could we just mark NumericArray final? @pitrou
There was a problem hiding this comment.
This might keep same style from PrimitiveArray, which initializes raw_values_ in ctor. Don't know should we change here
github-actions
bot
added
awaiting changes
|
Gentle ping @pitrou |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
See #44541
What changes are included in this PR?
NumericArray<T>not using child's ctor.Are these changes tested?
Yes
Are there any user-facing changes?
Bugfix