Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-43197: [C++][AzureFS] Ignore password field in URI #44220

Merged
merged 1 commit into from
Sep 30, 2024

Conversation

kou
Copy link
Member

@kou kou commented Sep 25, 2024

Rationale for this change

Other Azure Blob Storage based filesystem API implementations don't use password field in URI.

We don't use it too for compatibility.

What changes are included in this PR?

Ignore password field.

Are these changes tested?

Yes.

Are there any user-facing changes?

Yes.

This PR includes breaking changes to public APIs.

Copy link

⚠️ GitHub issue #43197 has been automatically assigned in GitHub to PR creator.

@kou
Copy link
Member Author

kou commented Sep 30, 2024

+1

@kou kou merged commit b1d9f85 into apache:main Sep 30, 2024
37 of 39 checks passed
@kou kou deleted the cpp-azurefs-disallow-password branch September 30, 2024 23:50
@kou kou removed the awaiting committer review Awaiting committer review label Sep 30, 2024
Copy link

After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit b1d9f85.

There was 1 benchmark result indicating a performance regression:

The full Conbench report has more details. It also includes information about 4 possible false positives for unstable benchmarks that are known to sometimes produce them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant