Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-43519: [Python][CI] Add Python 3.13 conda test build #44192

Merged
merged 6 commits into from
Oct 11, 2024

Conversation

jorisvandenbossche
Copy link
Member

@jorisvandenbossche jorisvandenbossche commented Sep 23, 2024

Rationale for this change

When adding Python 3.13 support (#43539), conda was not yet ready to support Python 3.13. But over the last weeks most conda packages having being updated, so trying again.

@jorisvandenbossche
Copy link
Member Author

@github-actions crossbow submit test-conda-python-3.13

Copy link

⚠️ GitHub issue #43519 has been automatically assigned in GitHub to PR creator.

@github-actions github-actions bot added the awaiting committer review Awaiting committer review label Sep 23, 2024
Copy link

Revision: d158130

Submitted crossbow builds: ursacomputing/crossbow @ actions-c5bb1eee3e

Task Status
test-conda-python-3.13 GitHub Actions

@jorisvandenbossche
Copy link
Member Author

@github-actions crossbow submit test-conda-python-3.13

Copy link

Revision: 7ba4564

Submitted crossbow builds: ursacomputing/crossbow @ actions-1aece06481

Task Status
test-conda-python-3.13 GitHub Actions

@jorisvandenbossche
Copy link
Member Author

@github-actions crossbow submit test-conda-python-3.13

Copy link

Revision: 00694df

Submitted crossbow builds: ursacomputing/crossbow @ actions-e431ba77ed

Task Status
test-conda-python-3.13 GitHub Actions

@jorisvandenbossche
Copy link
Member Author

@github-actions crossbow submit test-conda-python-3.13

Copy link

Revision: fe77477

Submitted crossbow builds: ursacomputing/crossbow @ actions-e20eebe4b4

Task Status
test-conda-python-3.13 GitHub Actions

@jorisvandenbossche
Copy link
Member Author

@github-actions crossbow submit test-conda-python-*

Copy link

Revision: fe77477

Submitted crossbow builds: ursacomputing/crossbow @ actions-0c7af69ade

Task Status
test-conda-python-3.10 GitHub Actions
test-conda-python-3.10-cython2 GitHub Actions
test-conda-python-3.10-hdfs-2.9.2 GitHub Actions
test-conda-python-3.10-hdfs-3.2.1 GitHub Actions
test-conda-python-3.10-pandas-latest-numpy-latest GitHub Actions
test-conda-python-3.10-substrait GitHub Actions
test-conda-python-3.11 GitHub Actions
test-conda-python-3.11-dask-latest GitHub Actions
test-conda-python-3.11-dask-upstream_devel GitHub Actions
test-conda-python-3.11-hypothesis GitHub Actions
test-conda-python-3.11-pandas-latest-numpy-1.26 GitHub Actions
test-conda-python-3.11-pandas-latest-numpy-latest GitHub Actions
test-conda-python-3.11-pandas-nightly-numpy-nightly GitHub Actions
test-conda-python-3.11-pandas-upstream_devel-numpy-nightly GitHub Actions
test-conda-python-3.11-spark-master GitHub Actions
test-conda-python-3.12 GitHub Actions
test-conda-python-3.12-cpython-debug GitHub Actions
test-conda-python-3.13 GitHub Actions
test-conda-python-3.9 GitHub Actions
test-conda-python-3.9-pandas-1.1.3-numpy-1.19.5 GitHub Actions
test-conda-python-emscripten GitHub Actions

@jorisvandenbossche
Copy link
Member Author

Not entirely sure if it is worth adding this as long as we have to specify a custom channel (--channel conda-forge/label/python_rc), but the current version of the PR seems to work.

$([ "$python" == $(gdb --batch --eval-command 'python import sys; print(f"{sys.version_info.major}.{sys.version_info.minor}")') ] && echo "gdb") \
"python=${python}.*=*_cpython" \
"python=${python}.*=*_cp*" \
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The reason for this change is that the build output name changed recently in https://github.com/conda-forge/python-feedstock/pull/679/files#diff-f3725a55bf339595bf865fec73bda8ac99f283b0810c205442021f29c06eea9aR106

While before the build name always ended with _cpython, they now changed it to end with _{{ abi_tag }} (so in practice something like _cp313.

The above _cp* should work for both cases, while still ensuring we get cpython and not pypy

@github-actions github-actions bot added awaiting changes Awaiting changes and removed awaiting committer review Awaiting committer review labels Sep 24, 2024
@github-actions github-actions bot removed the awaiting changes Awaiting changes label Oct 10, 2024
@jorisvandenbossche
Copy link
Member Author

@github-actions crossbow submit test-conda-python-*

@github-actions github-actions bot added the awaiting change review Awaiting change review label Oct 10, 2024
Copy link

Revision: 4d6f5c6

Submitted crossbow builds: ursacomputing/crossbow @ actions-445d0307de

Task Status
test-conda-python-3.10 GitHub Actions
test-conda-python-3.10-cython2 GitHub Actions
test-conda-python-3.10-hdfs-2.9.2 GitHub Actions
test-conda-python-3.10-hdfs-3.2.1 GitHub Actions
test-conda-python-3.10-pandas-latest-numpy-latest GitHub Actions
test-conda-python-3.10-substrait GitHub Actions
test-conda-python-3.11 GitHub Actions
test-conda-python-3.11-dask-latest GitHub Actions
test-conda-python-3.11-dask-upstream_devel GitHub Actions
test-conda-python-3.11-hypothesis GitHub Actions
test-conda-python-3.11-pandas-latest-numpy-1.26 GitHub Actions
test-conda-python-3.11-pandas-latest-numpy-latest GitHub Actions
test-conda-python-3.11-pandas-nightly-numpy-nightly GitHub Actions
test-conda-python-3.11-pandas-upstream_devel-numpy-nightly GitHub Actions
test-conda-python-3.11-spark-master GitHub Actions
test-conda-python-3.12 GitHub Actions
test-conda-python-3.12-cpython-debug GitHub Actions
test-conda-python-3.13 GitHub Actions
test-conda-python-3.9 GitHub Actions
test-conda-python-3.9-pandas-1.1.3-numpy-1.19.5 GitHub Actions
test-conda-python-emscripten GitHub Actions

@raulcd
Copy link
Member

raulcd commented Oct 10, 2024

Thanks @jorisvandenbossche , I missed that PR

Copy link
Member

@raulcd raulcd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@raulcd raulcd merged commit 45b3697 into apache:main Oct 11, 2024
37 checks passed
@raulcd raulcd removed the awaiting change review Awaiting change review label Oct 11, 2024
@github-actions github-actions bot added the awaiting merge Awaiting merge label Oct 11, 2024
raulcd pushed a commit that referenced this pull request Oct 11, 2024
### Rationale for this change

When adding Python 3.13 support (#43539), conda was not yet ready to support Python 3.13. But over the last weeks most conda packages having being updated, so trying again.

* GitHub Issue: #43519

Authored-by: Joris Van den Bossche <[email protected]>
Signed-off-by: Raúl Cumplido <[email protected]>
Copy link

After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit 45b3697.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details. It also includes information about 1 possible false positive for unstable benchmarks that are known to sometimes produce them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting merge Awaiting merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants