-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GH-43519: [Python][CI] Add Python 3.13 conda test build #44192
Conversation
@github-actions crossbow submit test-conda-python-3.13 |
|
Revision: d158130 Submitted crossbow builds: ursacomputing/crossbow @ actions-c5bb1eee3e
|
@github-actions crossbow submit test-conda-python-3.13 |
Revision: 7ba4564 Submitted crossbow builds: ursacomputing/crossbow @ actions-1aece06481
|
@github-actions crossbow submit test-conda-python-3.13 |
Revision: 00694df Submitted crossbow builds: ursacomputing/crossbow @ actions-e431ba77ed
|
@github-actions crossbow submit test-conda-python-3.13 |
Revision: fe77477 Submitted crossbow builds: ursacomputing/crossbow @ actions-e20eebe4b4
|
@github-actions crossbow submit test-conda-python-* |
Revision: fe77477 Submitted crossbow builds: ursacomputing/crossbow @ actions-0c7af69ade |
Not entirely sure if it is worth adding this as long as we have to specify a custom channel ( |
$([ "$python" == $(gdb --batch --eval-command 'python import sys; print(f"{sys.version_info.major}.{sys.version_info.minor}")') ] && echo "gdb") \ | ||
"python=${python}.*=*_cpython" \ | ||
"python=${python}.*=*_cp*" \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The reason for this change is that the build output name changed recently in https://github.com/conda-forge/python-feedstock/pull/679/files#diff-f3725a55bf339595bf865fec73bda8ac99f283b0810c205442021f29c06eea9aR106
While before the build name always ended with _cpython
, they now changed it to end with _{{ abi_tag }}
(so in practice something like _cp313
.
The above _cp*
should work for both cases, while still ensuring we get cpython and not pypy
@github-actions crossbow submit test-conda-python-* |
Revision: 4d6f5c6 Submitted crossbow builds: ursacomputing/crossbow @ actions-445d0307de |
Thanks @jorisvandenbossche , I missed that PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
### Rationale for this change When adding Python 3.13 support (#43539), conda was not yet ready to support Python 3.13. But over the last weeks most conda packages having being updated, so trying again. * GitHub Issue: #43519 Authored-by: Joris Van den Bossche <[email protected]> Signed-off-by: Raúl Cumplido <[email protected]>
After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit 45b3697. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about 1 possible false positive for unstable benchmarks that are known to sometimes produce them. |
Rationale for this change
When adding Python 3.13 support (#43539), conda was not yet ready to support Python 3.13. But over the last weeks most conda packages having being updated, so trying again.