Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GH-37756: [Format][Docs] Document IPC Compression #43950

Merged
merged 18 commits into from
Sep 17, 2024
Merged

GH-37756: [Format][Docs] Document IPC Compression #43950

merged 18 commits into from
Sep 17, 2024

Conversation

AlenkaF
Copy link
Member

@AlenkaF AlenkaF commented Sep 4, 2024 •
edited by github-actions bot
Loading

Rationale for this change

There is no information about buffer compression of the record batch IPC message in the format docs (https://arrow.apache.org/docs/format/Columnar.html).

What changes are included in this PR?

New paragraph is added with basic information about buffer compression in IPC.

Are these changes tested?

No, it is only documentation update.

Are there any user-facing changes?

No, only documentation update.

@github-actions github-actions bot added awaiting changes Awaiting changes and removed awaiting review Awaiting review labels Sep 4, 2024
@ianmcook
Copy link
Member

ianmcook commented Sep 4, 2024

@github-actions crossbow submit preview-docs

@ianmcook
Copy link
Member

ianmcook commented Sep 4, 2024

Thanks @AlenkaF, this is a much-needed addition!

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 4, 2024

Revision: 2f7620b

Submitted crossbow builds: ursacomputing/crossbow @ actions-64d2971931

Task Status
preview-docs GitHub Actions

@github-actions github-actions bot added awaiting change review Awaiting change review and removed awaiting changes Awaiting changes labels Sep 4, 2024
@github-actions github-actions bot added awaiting changes Awaiting changes and removed awaiting change review Awaiting change review labels Sep 4, 2024
@ianmcook ianmcook mentioned this pull request Sep 4, 2024
Open
kou
kou reviewed Sep 4, 2024
View reviewed changes
docs/source/format/Columnar.rst Outdated Show resolved Hide resolved
docs/source/format/Columnar.rst Outdated Show resolved Hide resolved
@github-actions github-actions bot added awaiting change review Awaiting change review and removed awaiting changes Awaiting changes labels Sep 5, 2024
@AlenkaF
Copy link
Member Author

AlenkaF commented Sep 5, 2024

@github-actions crossbow submit preview-docs

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 5, 2024

Revision: d9ad1b2

Submitted crossbow builds: ursacomputing/crossbow @ actions-5f500a8373

Task Status
preview-docs GitHub Actions

@github-actions github-actions bot added the awaiting change review Awaiting change review label Sep 12, 2024
jorisvandenbossche
jorisvandenbossche reviewed Sep 12, 2024
View reviewed changes
Copy link
Member

@jorisvandenbossche jorisvandenbossche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few more minor textual suggestions

docs/source/format/Columnar.rst Outdated Show resolved Hide resolved
docs/source/format/Columnar.rst Show resolved Hide resolved
docs/source/format/Columnar.rst Outdated Show resolved Hide resolved
docs/source/format/Columnar.rst Outdated Show resolved Hide resolved
@github-actions github-actions bot added awaiting changes Awaiting changes and removed awaiting change review Awaiting change review labels Sep 12, 2024
@AlenkaF @jorisvandenbossche
Apply suggestions from code review
fb03ef0 
Co-authored-by: Joris Van den Bossche <[email protected]>
@github-actions github-actions bot added awaiting change review Awaiting change review and removed awaiting changes Awaiting changes labels Sep 12, 2024
@github-actions github-actions bot added awaiting changes Awaiting changes and removed awaiting change review Awaiting change review labels Sep 12, 2024
@github-actions github-actions bot added awaiting change review Awaiting change review and removed awaiting changes Awaiting changes labels Sep 13, 2024
@ianmcook ianmcook mentioned this pull request Sep 13, 2024
Merged
@ianmcook
Copy link
Member

Last call for additional comments. Let's merge this in time for the 18.0.0 release.

@ianmcook
Copy link
Member

@github-actions crossbow submit preview-docs

@github-actions GitHub Actions
Copy link

Revision: e684f54

Submitted crossbow builds: ursacomputing/crossbow @ actions-3d575a7c02

Task Status
preview-docs GitHub Actions

@github-actions github-actions bot added awaiting changes Awaiting changes awaiting change review Awaiting change review and removed awaiting change review Awaiting change review awaiting changes Awaiting changes labels Sep 17, 2024
@ianmcook ianmcook merged commit c067d9b into apache:main Sep 17, 2024
6 checks passed
@ianmcook ianmcook mentioned this pull request Sep 17, 2024
Closed
@ianmcook
Copy link
Member

Thanks @AlenkaF!

@conbench-apache-arrow conbench-apache-arrow
Copy link

After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit c067d9b.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details. It also includes information about 3 possible false positives for unstable benchmarks that are known to sometimes produce them.

@AlenkaF AlenkaF deleted the gh-37756-ipc-compression branch September 18, 2024 11:54
@felipecrv
Copy link
Contributor

Very happy to see this merged! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@felipecrv felipecrv felipecrv left review comments

@ianmcook ianmcook ianmcook approved these changes

@jorisvandenbossche jorisvandenbossche jorisvandenbossche left review comments

@kou kou kou approved these changes

@mapleFU mapleFU mapleFU approved these changes

Assignees
No one assigned
Labels
awaiting change review Awaiting change review Component: Documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@AlenkaF @ianmcook @mapleFU @jorisvandenbossche @felipecrv @kou