Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-37213: [C#] Updating a reference to FlatBuffers missed due to rebase/merge conflict #37214

Merged
merged 1 commit into from
Aug 16, 2023

Conversation

westonpace
Copy link
Member

@westonpace westonpace commented Aug 16, 2023

Rationale for this change

The build was broken

What changes are included in this PR?

Updated a newly introduced reference to using FlatBuffers to be using Google.FlatBuffers

Are these changes tested?

Yes

Are there any user-facing changes?

No

@github-actions
Copy link

⚠️ GitHub issue #37213 has been automatically assigned in GitHub to PR creator.

@westonpace
Copy link
Member Author

There is still a timeout in one of the jobs but it looks like that timeout has been failing since before this bug so I'm pretty sure its unrelated. I'm going to go ahead and merge this as it is so minor.

@westonpace westonpace merged commit d0c18a6 into apache:main Aug 16, 2023
@westonpace westonpace removed the awaiting committer review Awaiting committer review label Aug 16, 2023
@conbench-apache-arrow
Copy link

After merging your PR, Conbench analyzed the 5 benchmarking runs that have been run so far on merge-commit d0c18a6.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details. It also includes information about possible false positives for unstable benchmarks that are known to sometimes produce them.

loicalleyne pushed a commit to loicalleyne/arrow that referenced this pull request Nov 13, 2023
…o rebase/merge conflict (apache#37214)

### Rationale for this change

The build was broken

### What changes are included in this PR?

Updated a newly introduced reference to `using FlatBuffers` to be `using Google.FlatBuffers`

### Are these changes tested?

Yes

### Are there any user-facing changes?

No
* Closes: apache#37213

Authored-by: Weston Pace <[email protected]>
Signed-off-by: Weston Pace <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[C#] Fix bug introduced by merge of 35699 without rebase
1 participant