Skip to content

Commit

Permalink
GH-44574: [Release] Ensure using the release tag to build binaries (#…
Browse files Browse the repository at this point in the history
…44577)

### Rationale for this change

We may use wrong commit with the current `dev/release/03-binary-submit.sh` because it uses the current commit on the checkout-ed branch.

### What changes are included in this PR?

Specify `--arrow-sha` explicitly to ensure using the release tag.

### Are these changes tested?

Yes.

### Are there any user-facing changes?

No.
* GitHub Issue: #44574

Authored-by: Sutou Kouhei <[email protected]>
Signed-off-by: Raúl Cumplido <[email protected]>
  • Loading branch information
kou authored Oct 30, 2024
1 parent 916be63 commit feafddd
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion dev/release/03-binary-submit.sh
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,8 @@ release_tag="apache-arrow-${version}-rc${rc}"
rc_branch="release-${version_with_rc}"

: ${ARROW_REPOSITORY:="apache/arrow"}
: ${ARROW_BRANCH:=$release_tag}
: ${ARROW_BRANCH:=${release_tag}}
: ${ARROW_SHA:=${release_tag}}

# archery will submit a job with id: "${crossbow_job_prefix}-0" unless there
# are jobs submitted with the same prefix (the integer at the end is auto
Expand All @@ -43,6 +44,7 @@ archery crossbow submit \
--arrow-version ${version_with_rc} \
--arrow-remote "https://github.com/${ARROW_REPOSITORY}" \
--arrow-branch ${ARROW_BRANCH} \
--arrow-sha ${ARROW_SHA} \
--group packaging

# archery will add a comment to the automatically generated PR to track
Expand Down

0 comments on commit feafddd

Please sign in to comment.