Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

More trivial implementation of Box<dyn AsyncArrowWriter> and Box<dyn AsyncArrowReader> #6748

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

More trivial implementation of Box<dyn AsyncArrowWriter> and Box<dyn AsyncArrowReader> #6748

wants to merge 1 commit into from
+2 −2

Conversation

ethe
Copy link
Contributor

@ethe ethe commented Nov 18, 2024 •
edited
Loading

In the current,

impl AsyncFileReader for Box<dyn AsyncFileReader> {
    ...
}

equals to

impl AsyncFileReader for Box<dyn AsyncFileReader + 'static> {
    ...
}

which 'static bound is not necessary, I removed this bound to make it more trivial

@github-actions github-actions bot added the parquet Changes to the parquet crate label Nov 18, 2024
@ethe ethe changed the title Wilder implementor of Box<dyn AsyncArrowWriter> and Box<dyn AsyncArrowReader> in parquet More trivial implementation of Box<dyn Async Arrow Writer> and Box<dyn AsyncArrowReader> Nov 18, 2024
@ethe ethe changed the title More trivial implementation of Box<dyn Async Arrow Writer> and Box<dyn AsyncArrowReader> More trivial implementation of Box<dyn AsyncArrowWriter> and Box<dyn AsyncArrowReader> Nov 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
parquet Changes to the parquet crate
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ethe