feat: support schema change by idx and reverse #4985
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: fan <[email protected]>
tustvold
reviewed
Oct 24, 2023
arrow-schema/src/schema.rs
Outdated
Comment on lines
60
to
63
| /// Change the FieldRef as index `idx` | ||
| /// if index out of bounds, will panic | ||
| pub fn change_field(&mut self, idx: usize, field: impl Into<FieldRef>) { | ||
| self.fields[idx] = field.into() |
There was a problem hiding this comment.
Suggested change
| /// Change the FieldRef as index `idx` | |
| /// if index out of bounds, will panic | |
| pub fn change_field(&mut self, idx: usize, field: impl Into<FieldRef>) { | |
| self.fields[idx] = field.into() | |
| /// Returns a mutable reference to the field at `idx` | |
| pub fn field_mut(&mut self, idx: usize) -> &mut FieldRef { | |
| &mut self.fields[idx] |
What do you think about this instead?
There was a problem hiding this comment.
I think it's good!!! 😄
Signed-off-by: fan <[email protected]>
|
Thank you |
Thans for your review. 😍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #4908.
Rationale for this change
What changes are included in this PR?
Are there any user-facing changes?