Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: SSLKEYLOGFILE support for flight CLI #4875

Closed
wants to merge 1 commit into from
Closed

feat: SSLKEYLOGFILE support for flight CLI #4875

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,3 +93,6 @@ arrow-string = { version = "47.0.0", path = "./arrow-string" }
parquet = { version = "47.0.0", path = "./parquet", default-features = false }

chrono = { version = "0.4.31", default-features = false, features = ["clock"] }

[patch.crates-io]
tonic = { git = "https://github.com/crepererum/tonic.git", branch = "crepererum/keylog" }
15 changes: 14 additions & 1 deletion arrow-flight/src/bin/flight_sql_client.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,6 +85,14 @@ struct ClientArgs {
#[clap(long)]
tls: bool,

/// Dump TLS key log.
///
/// The target file is specified by the `SSLKEYLOGFILE` environment variable.
///
/// Required `--tls`.
#[clap(long, requires = "tls")]
key_log: bool,

/// Server host.
#[clap(long)]
host: String,
Expand Down Expand Up @@ -235,7 +243,12 @@ async fn setup_client(args: ClientArgs) -> Result<FlightSqlServiceClient<Channel
.keep_alive_while_idle(true);

if args.tls {
let tls_config = ClientTlsConfig::new();
let mut tls_config = ClientTlsConfig::new();

if args.key_log {
tls_config = tls_config.use_key_log();
}

endpoint = endpoint
.tls_config(tls_config)
.context("create TLS endpoint")?;
Expand Down